Skip to content

Triage party config and docs #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 10, 2021
Merged

Triage party config and docs #3740

merged 18 commits into from
Jun 10, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 3, 2021

Adds the docs and configuration for Triage party.

@balopat balopat requested review from cduck, vtomole and a team as code owners February 3, 2021 09:12
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Feb 3, 2021
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs in this PR would benefit from a general style-consistency sweep. Points to consider:

  • Sentence capitalization
  • Bolding or code-formatting of specific keywords
  • Periods at the end of list items

I don't think we have explicit guidance on these items; my main concern is that we use a consistent style within a given doc.

@balopat
Copy link
Contributor Author

balopat commented Feb 10, 2021

Docs in this PR would benefit from a general style-consistency sweep. Points to consider:

  • Sentence capitalization
  • Bolding or code-formatting of specific keywords
  • Periods at the end of list items

I don't think we have explicit guidance on these items; my main concern is that we use a consistent style within a given doc.

Oh right, I remember now, this was parked for a long time on my machine. I used a Google docs addon for markdown conversion to create this md from the triage RFC :) I'll go through it thoroughly again. Thanks for the detailed review!

@balopat
Copy link
Contributor Author

balopat commented Feb 12, 2021

@95-martin-orion this is ready for another round of reviews!

Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Episode 2: Nothing But Nits

...I don't anticipate a sequel, this one's straight to DVD 😝

@balopat balopat requested a review from 95-martin-orion June 7, 2021 18:46
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this line was missed in the tag-to-inline-code pass.

This was referring to the fact that "triage/accepted or triage/discuss" ought to be "triage/accepted or triage/discuss".

One other nit besides that, but I'm marking approval. It feels like I first looked at this a week ago - where did the time go?

@balopat
Copy link
Contributor Author

balopat commented Jun 10, 2021

Thank you for the final review!!!

Looks like this line was missed in the tag-to-inline-code pass.

This was referring to the fact that "triage/accepted or triage/discuss" ought to be "triage/accepted or triage/discuss".

oh got it, will fix.

One other nit besides that, but I'm marking approval. It feels like I first looked at this a week ago - where did the time go?

Hahahaha, I know, this was more than 4 months ago haha

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 10, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 10, 2021
@CirqBot CirqBot merged commit 1d1f3a8 into quantumlib:master Jun 10, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 10, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds the docs and configuration for Triage party.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants