-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Triage party config and docs #3740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs in this PR would benefit from a general style-consistency sweep. Points to consider:
- Sentence capitalization
- Bolding or
code-formatting
of specific keywords - Periods at the end of list items
I don't think we have explicit guidance on these items; my main concern is that we use a consistent style within a given doc.
Oh right, I remember now, this was parked for a long time on my machine. I used a Google docs addon for markdown conversion to create this md from the triage RFC :) I'll go through it thoroughly again. Thanks for the detailed review! |
@95-martin-orion this is ready for another round of reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Episode 2: Nothing But Nits
...I don't anticipate a sequel, this one's straight to DVD 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line was missed in the tag-to-inline-code pass.
This was referring to the fact that "triage/accepted or triage/discuss" ought to be "triage/accepted
or triage/discuss
".
One other nit besides that, but I'm marking approval. It feels like I first looked at this a week ago - where did the time go?
Thank you for the final review!!!
oh got it, will fix.
Hahahaha, I know, this was more than 4 months ago haha |
Adds the docs and configuration for Triage party.
Adds the docs and configuration for Triage party.