Skip to content

Updated secretmanager ref to v1 #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

gwhitehawk
Copy link
Contributor

No description provided.

@gwhitehawk gwhitehawk requested review from cduck, vtomole and a team as code owners February 8, 2021 18:23
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Feb 8, 2021
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this secretmanager a recent/new thing?

@gwhitehawk
Copy link
Contributor Author

Is this secretmanager a recent/new thing?

It's been in GA since Q1 2020, so it's about time to update. We still support beta but adding new features exclusively to v1 version.

@balopat
Copy link
Contributor

balopat commented Feb 8, 2021

Is this secretmanager a recent/new thing?

It's for the automerge bot being able to run in Google Cloud. See https://github.com/quantumlib/Cirq/blob/master/dev_tools/cirq-infra/README.md

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 8, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 8, 2021
@CirqBot CirqBot merged commit d57fa67 into quantumlib:master Feb 8, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 8, 2021
balopat added a commit that referenced this pull request Feb 9, 2021
balopat added a commit that referenced this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants