Move decompose-and-act-on strategy to act_on file and reuse it in all ActOn*Args
#3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in all ActOn*Args. Allows ISWAP to be run to CliffordSim without explicit act_on implementation
smitsanghavi
changed the title
act_on file and reuse it in all ActOn*Argsact_on file and reuse it in all ActOn*Args
|
This is already done in #3841 |
Thanks! I'll close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows new gates to just define their decompositions and expect to be supported on relevant simulators. For e.g.
CliffordSimulatornow supportsISWAPwithout explicitly having to define_act_on_for it since ISWAP has a decomposition to Clifford gates specified.