Fix most numpy type errors in cirq/ops #3997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `check/mypy --next | grep cirq/ops` this fixes almost all of the issues raised with simple modifications. There is a looming problem with places where we use `numbers.Complex`, which is a nice generalization for Union[int, float, complex] but does not play nice with numpy type information.
viathor
approved these changes
Apr 7, 2021
viathor
approved these changes
Apr 7, 2021
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
vtomole
reviewed
Apr 8, 2021
| labels: Dict['cirq.Pauli', str] = { | ||
| pauli_gates.X: 'X', | ||
| pauli_gates.Y: 'Y', | ||
| pauli_gates.Z: '@', |
There was a problem hiding this comment.
Not relevant to this PR: I'm curious as to why this is @ instead of Z
There was a problem hiding this comment.
I suppose it is to make the diagram resemble the standard quantum circuit symbol for controlled-Z.
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
check/mypy --next | grep cirq/opsthis fixes almost all of the issues raised with simple modifications.There is a looming problem with places where we use
numbers.Complex, which is a nice generalization for Union[int, float, complex] but does not play nice with numpy type information.Towards #3767