Disallow empty measurement keys and fix tests using empty keys #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitsanghavi
requested review from
cduck,
ColemanCollins,
dabacon,
gmauricio,
HGSilveri,
nakardo,
vtomole and
a team
as code owners
95-martin-orion
requested review from
95-martin-orion
and removed request for
viathor
|
Discussed offline - this may not be necessary if we choose to auto-convert keyless gates into qubit-named gates. Holding off on merge until @smitsanghavi confirms his decision. |
|
ping @95-martin-orion @smitsanghavi is this to be closed or pushed forward? |
|
Closing this as we had opted for a different solution (auto-convert "keyless" gates to qubit-based naming). If we need to revisit this (or decide that this PR was the correct choice) we can reopen this PR. |
|
Reviving this since we decided to revert the qubit based auto-naming. |
95-martin-orion
approved these changes
Aug 2, 2021
dstrain115
added
the
BREAKING CHANGE
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…umlib#4060) * Empty keys are illegal now * merge * fix duplicate post-inits
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…umlib#4060) * Empty keys are illegal now * merge * fix duplicate post-inits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4040