Skip to content

add binary_paintshop example to ionq #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021

Conversation

MLeib
Copy link
Contributor

@MLeib MLeib commented May 11, 2021

No description provided.

@MLeib MLeib requested a review from mpharrigan May 11, 2021 09:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented May 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 11, 2021
@MLeib
Copy link
Contributor Author

MLeib commented May 11, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Makes googlebot stop complaining. and removed cla: no labels May 11, 2021
@balopat balopat requested review from balopat and removed request for mpharrigan May 12, 2021 01:06
@balopat balopat force-pushed the ionq_bpsp_example branch from 20f9b02 to 3e22219 Compare May 12, 2021 01:21
@balopat
Copy link
Contributor

balopat commented May 12, 2021

Hi @MLeib, I fixed the header and added the _book.yaml entry for our site. I also removed an API key that was left in there, and in order to remove it from git history I rebased your commit. You won't be able to push from your local branch because of this, I recommend removing your local branch (git branch -D ionq_bpsp_example) and checkout your remote branch again (git checkout origin/ionq_bpsp_example -b ionq_bpsp_example or similar).

@dabacon
Copy link
Collaborator

dabacon commented May 17, 2021

A couple of small comments. I will take another pass on this to flesh it out a little bit more, but let's get this one submitted.

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the two small details, approval to submit.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 19, 2021
@dabacon dabacon merged commit 38ed9ac into quantumlib:master May 19, 2021
@balopat balopat removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 19, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants