Remove separate script for nightly devsite diff #4105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
approved these changes
May 13, 2021
| "The url prefix for links to code.", | ||
| ) | ||
|
|
||
| flags.DEFINE_bool("search_hints", True, "Include metadata search hints in the generated files") | ||
|
|
||
| flags.DEFINE_string("site_path", "quark/cirq/api_docs/python", "Path prefix in the _toc.yaml") | ||
| flags.DEFINE_string("site_path", "reference/python", "Path prefix in the _toc.yaml") |
There was a problem hiding this comment.
What prompted this change? At first glance it doesn't seem related to either of the linked issues.
There was a problem hiding this comment.
This is non-material, because the internal caller overrides this anyway with the correct string, but it was an outdated default value (we had this URL structure when we first had the internal staging site hosted on tensorflow's site) that I just updated. I'll include that in the PR description.
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
After the v0.11 release there is no need for a separate script for the extra modules. I also added the fix for the code_prefix_url which should fix the issue with the broken "View Source" functionality. An unrelated nit that I changed is the default value for the site_url parameter - we had this URL structure when we first had the internal staging site hosted on tensorflow's site, now it's in line with what we have live. For the next module extractions this script will need to cater for both the stable (v0.11) and the nightly (from master) version, it will be more manageable that way. Fixes quantumlib#4066. Fixes quantumlib#4104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the v0.11 release there is no need for a separate script for the extra modules.
I also added the fix for the code_prefix_url which should fix the issue with the broken "View Source" functionality.
An unrelated nit that I changed is the default value for the site_url parameter - we had this URL structure when we first had the internal staging site hosted on tensorflow's site, now it's in line with what we have live.
For the next module extractions this script will need to cater for both the stable (v0.11) and the nightly (from master) version, it will be more manageable that way.
Fixes #4066.
Fixes #4104.