Skip to content

Minor improvements to echoes tutorial #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

rmlarose
Copy link
Contributor

Closes #4122 if @mpharrigan is okay with reshaping. Other improvements: get calibration directly and use sampler instead of engine.

@rmlarose rmlarose requested review from cduck, vtomole, wcourtney and a team as code owners May 23, 2021 20:47
@rmlarose rmlarose requested a review from 95-martin-orion May 23, 2021 20:47
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label May 23, 2021
@@ -108,22 +108,12 @@
"metadata": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could seed the global numpy random generator to reduce churn in the output cells like this


Reply via ReviewNB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(reduce future churn, that is)

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really nice

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 4, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 4, 2021
@CirqBot CirqBot merged commit 8b5866f into quantumlib:master Jun 4, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 4, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Closes quantumlib#4122 if @mpharrigan is okay with reshaping. Other improvements: get calibration directly and use sampler instead of engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Echoes notebook: readable results structure
4 participants