Add method to get "mapped_circuit" from CircuitOperations #4188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapped circuit is equivalent to the inner circuit, but with various maps and transformations applied (qubit map, param map, measurement map, repetitions, repetition ids). The mapping can be applied deeply, in which case contained CircuitOperations are expanded recursively, or shallowly, in which case contained CircuitOperations are left unchanged. To implement the deep mapping, we add a map_ops method on AbstractCircuit that applies a function to each op in the circuit and then recombines them in a way that preserves moment structure as much as possible. Fixes #3783
95-martin-orion
requested review from
tanujkhattar
and removed request for
smitsanghavi
maffoo
reviewed
Jun 22, 2021
dstrain115
reviewed
Jun 22, 2021
| circuit.map_ops(lambda op: func(op, rep)) for rep in self.repetition_ids | ||
| ) | ||
|
|
||
| def mapped_op(self, deep: bool = False) -> 'cirq.CircuitOperation': |
There was a problem hiding this comment.
Done, although I have question on this. I would normally omit docstrings for one-line methods - is the devsite documentation the primary motivation for including a docstring in such cases?
maffoo
approved these changes
Jun 24, 2021
| result = self.circuit.unfreeze() | ||
| result = result.transform_qubits(lambda q: self.qubit_map.get(q, q)) | ||
| def mapped_circuit(self, deep: bool = False) -> 'cirq.Circuit': | ||
| """Applies all maps to the cotained circuit and returns the result. |
There was a problem hiding this comment.
Suggested change
| """Applies all maps to the cotained circuit and returns the result. | |
| """Applies all maps to the contained circuit and returns the result. |
Comment on lines
192
to
193
| deep: If true, this will also call mapped_circuit on any | ||
| CircuitOperations this object contains. |
There was a problem hiding this comment.
Suggested change
| deep: If true, this will also call mapped_circuit on any | |
| CircuitOperations this object contains. | |
| deep: If true, this will also call mapped_circuit on any | |
| CircuitOperations this object contains. |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…#4188) * Add method to get "mapped_circuit" from CircuitOperation The mapped circuit is equivalent to the inner circuit, but with various maps and transformations applied (qubit map, param map, measurement map, repetitions, repetition ids). The mapping can be applied deeply, in which case contained CircuitOperations are expanded recursively, or shallowly, in which case contained CircuitOperations are left unchanged. To implement the deep mapping, we add a map_ops method on AbstractCircuit that applies a function to each op in the circuit and then recombines them in a way that preserves moment structure as much as possible. Fixes quantumlib#3783 * Rework to handle repetition_ids properly when deep=False * Modernize and test mapped_circuit * Formatting * Clearer function names and docstrings. * Fix typos Co-authored-by: Matthew Neeley <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…#4188) * Add method to get "mapped_circuit" from CircuitOperation The mapped circuit is equivalent to the inner circuit, but with various maps and transformations applied (qubit map, param map, measurement map, repetitions, repetition ids). The mapping can be applied deeply, in which case contained CircuitOperations are expanded recursively, or shallowly, in which case contained CircuitOperations are left unchanged. To implement the deep mapping, we add a map_ops method on AbstractCircuit that applies a function to each op in the circuit and then recombines them in a way that preserves moment structure as much as possible. Fixes quantumlib#3783 * Rework to handle repetition_ids properly when deep=False * Modernize and test mapped_circuit * Formatting * Clearer function names and docstrings. * Fix typos Co-authored-by: Matthew Neeley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #3785, bringing it up to date with the current state of
MeasurementKeybehavior and adding tests. Use of themapped_circuitmethod will allow the moment structure ofCircuitOperations to be preserved during deserialization.