Draw zero-target operations below circuit text diagrams as annotations #4234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95-martin-orion
requested changes
Jun 21, 2021
95-martin-orion
approved these changes
Jun 21, 2021
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
quantumlib#4234) Also fix a couple testing assert methods not hiding themselves from the traceback. This can change the diagrams of existing circuits, which will potentially break some downstream tests that assert the diagrams are something specific. However, I think having the information missing from the diagrams was more problematic. Fixes quantumlib#4232 Fixes quantumlib#4233
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
quantumlib#4234) Also fix a couple testing assert methods not hiding themselves from the traceback. This can change the diagrams of existing circuits, which will potentially break some downstream tests that assert the diagrams are something specific. However, I think having the information missing from the diagrams was more problematic. Fixes quantumlib#4232 Fixes quantumlib#4233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a couple testing assert methods not hiding themselves from the traceback.
This can change the diagrams of existing circuits, which will potentially break some downstream tests that assert the diagrams are something specific. However, I think having the information missing from the diagrams was more problematic.
Fixes #4232
Fixes #4233