Skip to content

update python version to 3.8 #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 21, 2021
Merged

update python version to 3.8 #4245

merged 6 commits into from
Jun 21, 2021

Conversation

stubbi
Copy link
Contributor

@stubbi stubbi commented Jun 21, 2021

resolves #4191

@balopat was this what you had in mind when opening the linked issue?

@stubbi stubbi requested review from cduck, vtomole and a team as code owners June 21, 2021 16:31
@stubbi stubbi requested a review from viathor June 21, 2021 16:31
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 21, 2021
balopat
balopat suggested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! Let's remove that TODO. Also if 3.9 passes, we can just close #3772 but if it's a bunch of failures we should do it in a separate PR.

stubbi added 2 commits June 21, 2021 19:47
@stubbi
introduce 3.9 later
21015e7
@stubbi
remove TODO, stuck with 3.6
778eaa3 
we can remove this TODO for now, we are stuck on 3.6 compatibility until Google upgrades to 3.7.
@stubbi stubbi requested a review from balopat June 21, 2021 18:06
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 21, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 21, 2021
@CirqBot CirqBot merged commit 4278277 into quantumlib:master Jun 21, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 21, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@stubbi @rht
update python version to 3.8 (quantumlib#4245)
60d8a81 
resolves quantumlib#4191 

@balopat was this what you had in mind when opening the linked issue?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@viathor viathor Awaiting requested review from viathor

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade CI tests to python 3.8
3 participants
@stubbi @balopat @CirqBot