Skip to content

Support decompose protocol on cirq.Moment #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Support decompose protocol on cirq.Moment #4251

merged 1 commit into from
Jun 22, 2021

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Jun 22, 2021

This also enables other protocols on Moment, such as the measurement keys protocol, which currently does not work.

@maffoo
Support decompose protocol on cirq.Moment
9c9167d 
This also enables other protocols on Moment, such as the measurement
keys protocol, which currently fails.
@maffoo maffoo requested review from cduck, vtomole and a team as code owners June 22, 2021 15:34
@maffoo maffoo requested a review from balopat June 22, 2021 15:34
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 22, 2021
balopat
balopat approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this, primarily because it is exactly equivalent to the behavior of AbstractCircuit._decompose_.

@maffoo maffoo added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 22, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 22, 2021
@CirqBot CirqBot merged commit 81d2097 into master Jun 22, 2021
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 22, 2021
@CirqBot CirqBot deleted the u/maffoo/moment-measure-keys branch June 22, 2021 15:56
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 22, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@maffoo @rht
Support decompose protocol on cirq.Moment (quantumlib#4251)
f6ba444 
This also enables other protocols on Moment, such as the measurement keys protocol, which currently does not work.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@maffoo
Support decompose protocol on cirq.Moment (quantumlib#4251)
1a90069 
This also enables other protocols on Moment, such as the measurement keys protocol, which currently does not work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maffoo @balopat @CirqBot