-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add an option to build a PauliSum from a Sympy Boolean expression #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@balopat This is one of the smaller PRs you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a little nit + it would be nice to add a little explanation in our docs/operators_and_observables.ipynb
Co-authored-by: Balint Pato <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sorry for the linter checks - I am reverting that change. |
docs/operators_and_observables.ipynb
Outdated
"id": "ba00a12b9fbd" | ||
}, | ||
"source": [ | ||
"A Pauli sum can also be constructed from a `Sympy` Boolean expression:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in the reference here to the paper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a final nit.
@balopat |
Automerge cancelled: A required status check is not present. Missing statuses: ['Format check'] |
Automerge cancelled: A required status check is not present. Missing statuses: ['Format check'] |
Following #4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
…antumlib#4282) As part of the the review quantumlib#3989 we could use the ability to build a PauliSum from a Boolean expression. This PR makes available that function (smaller change).
Following quantumlib#4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
…antumlib#4282) As part of the the review quantumlib#3989 we could use the ability to build a PauliSum from a Boolean expression. This PR makes available that function (smaller change).
Following quantumlib#4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
As part of the the review #3989 we could use the ability to build a PauliSum from a Boolean expression. This PR makes available that function (smaller change).