[WIP] NoCompile Tag for optimizers #4298

pgoiporia · 2021-07-07T23:17:57Z

google-cla · 2021-07-07T23:18:02Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-08T19:05:27Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-08T20:38:24Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pgoiporia · 2021-07-08T21:05:34Z

@googlebot I signed it!

google-cla · 2021-07-08T21:05:49Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-08T21:29:38Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-07-09T21:34:34Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

pgoiporia · 2021-07-09T21:37:02Z

Keeping log of changes
NoCompileTag applied to:

drop_negligible with testing
eject_phased_paulis without testing
drop_empty_moments doesn't require the tag

dstrain115

It would be really cool if we could have a more general testing util that makes sure that every compiler doesn't get affected by NoCompileTag.

dstrain115 · 2021-07-14T18:10:15Z

cirq-core/cirq/ops/tags.py

+
+
+class NoCompileTag:
+    """A TaggedOperation tag indicating that the operation is virtual.


Fix description. This docstring is taken from VirtualTag

dstrain115 · 2021-07-14T18:10:53Z

cirq-core/cirq/ops/tags_test.py

+
+def test_nocompile_tag():
+    tag1 = cirq.ops.VirtualTag()
+    tag2 = cirq.ops.VirtualTag()


Fix from virtual.

dstrain115 · 2021-07-14T18:11:14Z

cirq-core/cirq/optimizers/align_left.py

+#                    circuit.append(op, strategy=InsertStrategy.EARLIEST)
+#                else:
+#                    circuit.append(op)
+#        circuit=circuit_new


Delete commented code.

dstrain115 · 2021-07-14T18:12:40Z

cirq-core/cirq/optimizers/drop_negligible.py

@@ -38,6 +39,7 @@ def optimize_circuit(self, circuit: _circuit.Circuit) -> None:
            for op in moment.operations:
                if protocols.is_measurement(op):
                    continue
-                if protocols.trace_distance_bound(op) <= self.tolerance:
-                    deletions.append((moment_index, op))
+                if NoCompileTag not in op.tags:


Can combine these two conditions:

if protocols.is_measurement(op) or NoCompileTag in op.tags: continue

dstrain115 · 2021-07-14T18:12:55Z

cirq-core/cirq/optimizers/drop_negligible_test.py

-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-


Don't delete copyright please.

dstrain115 · 2021-07-14T18:15:26Z

cirq-core/cirq/optimizers/eject_phased_paulis.py

@@ -63,52 +64,53 @@ def optimize_circuit(self, circuit: circuits.Circuit):

        for moment_index, moment in enumerate(circuit):
            for op in moment.operations:
-                affected = [q for q in op.qubits if q in state.held_w_phases]
+                if NoCompileTag not in op.tags:


I would probably be consistent with above and say

if NoCompileTag in op.tags: continue

This avoids the negative condition and makes the change cleaner since all indentation doesn't change.

dstrain115 · 2021-07-14T18:16:00Z

cirq-core/cirq/optimizers/eject_phased_paulis.py

+
+            circuit.batch_remove(state.deletions)
+            circuit.batch_insert_into(state.inline_intos)
+            circuit.batch_insert(state.insertions)


Is this correct?

tanujkhattar · 2022-03-14T21:22:12Z

Support for NoCompileTags has been added to transformers as part of designing and implementing the new transformer framework.

See #4253 and #4722 for progress on migrating individual optimizers.

initial nocompile tag

20bf04e

google-cla bot added the cla: no label Jul 7, 2021

pgoiporia added 4 commits July 8, 2021 10:59

initial align_left

0935afc

initial align_left

ca3ce89

added tests for drop_negligible

366f127

test

913097e

drop negligible now compatible with NoCompileTag

8cb76ec

initial ejected_phased_paulis

5398e37

viathor assigned dstrain115 Jul 9, 2021

eject phased paulis without test

7242f45

dstrain115 self-requested a review July 14, 2021 18:09

dstrain115 reviewed Jul 14, 2021

View reviewed changes

tanujkhattar self-assigned this Jul 15, 2021

CirqBot added size: XL lines changed >1000 size: M 50< lines changed <250 and removed size: XL lines changed >1000 labels Aug 12, 2021

tanujkhattar closed this Mar 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] NoCompile Tag for optimizers #4298

[WIP] NoCompile Tag for optimizers #4298

pgoiporia commented Jul 7, 2021

google-cla bot commented Jul 7, 2021

google-cla bot commented Jul 8, 2021

google-cla bot commented Jul 8, 2021

pgoiporia commented Jul 8, 2021

google-cla bot commented Jul 8, 2021

google-cla bot commented Jul 8, 2021

google-cla bot commented Jul 9, 2021

pgoiporia commented Jul 9, 2021

dstrain115 left a comment

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

dstrain115 Jul 14, 2021

tanujkhattar commented Mar 14, 2022



		class NoCompileTag:
		"""A TaggedOperation tag indicating that the operation is virtual.

[WIP] NoCompile Tag for optimizers #4298

[WIP] NoCompile Tag for optimizers #4298

Conversation

pgoiporia commented Jul 7, 2021

google-cla bot commented Jul 7, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 8, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 8, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

pgoiporia commented Jul 8, 2021

google-cla bot commented Jul 8, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 8, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

google-cla bot commented Jul 9, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

pgoiporia commented Jul 9, 2021

dstrain115 left a comment

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

dstrain115 Jul 14, 2021

Choose a reason for hiding this comment

tanujkhattar commented Mar 14, 2022