Skip to content

Fix automerge checks #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2021
Merged

Fix automerge checks #4308

merged 3 commits into from
Jul 9, 2021

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jul 9, 2021

Fixes #4305.

@balopat balopat requested review from cduck, vtomole and a team as code owners July 9, 2021 21:19
@balopat balopat requested a review from dstrain115 July 9, 2021 21:19
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 9, 2021
Strilanc
Strilanc approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still fail beyond 100?

@balopat
Copy link
Contributor Author

balopat commented Jul 9, 2021

This will still fail beyond 100?

Yes, hopefully we won't have 100 checks, but yes, technically all the pageable queries should use paging in our automerge bot.

@balopat balopat merged commit 4852c46 into quantumlib:master Jul 9, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@balopat @rht
Fix automerge checks (quantumlib#4308)
96af501 
increase per_page for checks query in automerge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strilanc Strilanc Strilanc approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automerge failing on bogus missing checks
2 participants
@balopat @Strilanc