Re-alias TrialResult to Result in json. #4319
Conversation
| } | ||
| }, | ||
| { | ||
| "cirq_type": "Result", |
There was a problem hiding this comment.
this doesn't look like it was saved with an old version of cirq
There was a problem hiding this comment.
No this file wasn't. The test seemed to do more explicit checking than doing just something like load_json and seeing that it worked. It would also look for the TrialResult class somewhere which we got rid of and don't want to put back (I don't think) I did check the functionality hit here by doing the following thing:
In Cirq==0.8.0:
circuit = cirq.Circuit(cirq.H(q), cirq.measure(q))
results = cirq.Simulator().run(circuit)
cirq.to_json(results)Then in cirq master:
cirq.load_json(json_text=<text from previous snippet>)Which would fail. From there I just added this entry into the resolver cache and it started working again.
There was a problem hiding this comment.
I think that's what the _inward path is for as @balopat suggested
There was a problem hiding this comment.
Ahhh ok! Went ahead and renamed to _inward and things are looking good now. Switched back to TrialResult too.
| @@ -0,0 +1 @@ | |||
| [cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[True, True, False, True, False], [False, True, True, False, False], [True, False, True, False, True]], dtype=np.bool)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[1, 1, 0, 1, 0], [0, 1, 1, 0, 0], [1, 0, 1, 0, 1]], dtype=np.uint8)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.int8)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.int16)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.int32)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.int64)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.uint8)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.uint16)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.uint32)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.uint64)}), cirq.Result(params=cirq.ParamResolver({sympy.Symbol('a'): 0.5}), measurements={'m': np.array([[1, 1, 0, 1, 0], [0, 1, 1, 0, 0], [1, 0, 1, 0, 1]], dtype=np.uint8), 'n': np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]], dtype=np.int64)})] | |||
There was a problem hiding this comment.
This doesn't make too much sense to have actually, it's a bit of a lie, as it has cirq.Result as the type. We don't have cirq.TrialResult anymore, in my opinion repr based serialization is lost, unless we bring back cirq.TrialResult - which we don't want, that's why we deprecated it...
There was a problem hiding this comment.
Let's remove this file and keep the json_inward and the type mapping for now.
There was a problem hiding this comment.
The tests won't pass if I just delete the repr_inward. How do you want me to proceed ?
There was a problem hiding this comment.
There was a problem hiding this comment.
okay, sounds good, ¯_(ツ)_/¯
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Fixes quantumlib#4318 . Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
|
Are there any plans to cherry pick this into an 0.11.1 release? Otherwise ReCirq is blocked to update. |
Fixes quantumlib#4318 . Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
Fixes quantumlib#4318 . Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
Fixes quantumlib#4318 . Relatively small roll-back and re-aliasing of `TrialResult`. Json loading will now convert previously serialized `TrialResult` to a `Result` object. Confirmed on `cirq==0.8.0` and `cirq-dev`
Fixes #4318 .
Relatively small roll-back and re-aliasing of
TrialResult. Json loading will now convert previously serializedTrialResultto aResultobject. Confirmed oncirq==0.8.0andcirq-dev