Skip to content

IdentityGate optimizations for act_on and independent states (S) #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Jul 20, 2021

This exponentially improves perf on density matrix simulator for identity gates with several qubits. It also prevents merging independent states when an identity gate has multiple qubits.

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners July 20, 2021 16:17
@daxfohl daxfohl requested a review from viathor July 20, 2021 16:17
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 20, 2021
@daxfohl daxfohl changed the title act_on for identity act_on for identity (XS) Jul 24, 2021
@daxfohl daxfohl changed the title act_on for identity (XS) IdentityGate optimizations for act_on and independent states (S) Jul 26, 2021
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 28, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 28, 2021
@CirqBot CirqBot merged commit 2467e39 into quantumlib:master Jul 28, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 28, 2021
@daxfohl daxfohl deleted the id branch July 29, 2021 16:54
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…ntumlib#4340)

This exponentially improves perf on density matrix simulator for identity gates with several qubits. It also prevents merging independent states when an identity gate has multiple qubits.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…ntumlib#4340)

This exponentially improves perf on density matrix simulator for identity gates with several qubits. It also prevents merging independent states when an identity gate has multiple qubits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants