Allow intercepting decomposer while preserving structure. #4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
approved these changes
Jul 21, 2021
Comment on lines
-123
to
-143
| @overload | ||
| def decompose( | ||
| val: Any, | ||
| *, | ||
| intercepting_decomposer: Optional[OpDecomposer] = None, | ||
| fallback_decomposer: Optional[OpDecomposer] = None, | ||
| keep: Optional[Callable[['cirq.Operation'], bool]] = None, | ||
| ) -> List['cirq.Operation']: | ||
| pass | ||
|
|
||
|
|
||
| @overload | ||
| def decompose( | ||
| val: Any, | ||
| *, | ||
| intercepting_decomposer: Optional[OpDecomposer] = None, | ||
| fallback_decomposer: Optional[OpDecomposer] = None, | ||
| keep: Optional[Callable[['cirq.Operation'], bool]] = None, | ||
| on_stuck_raise: Union[None, TError, Callable[['cirq.Operation'], Optional[TError]]], | ||
| ) -> List['cirq.Operation']: | ||
| pass |
There was a problem hiding this comment.
Just curious why exactly are these definitions getting nuked ?
There was a problem hiding this comment.
Official answer: they're 100% redundant with the method they're overloading - if anything was calling one of these, it could instead call the remaining decompose method with no change in behavior.
Actual answer: mypy was complaining about these methods, and I realized they weren't necessary 😛
Comment on lines
+241
to
+243
| # pylint: disable=function-redefined | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: this looks like it's no longer needed.
There was a problem hiding this comment.
This is still needed for the other overloaded methods in this file.
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…#4343) This allows users to specify an intercepting decomposer (i.e. one that runs before default decomposition behavior) and use structure-preserving behavior (i.e. keeping `CircuitOperation`s but decomposing their contents) in the same `decompose` call. This is a prerequisite for allowing `CircuitOperation`s in `cirq.optimized_for_sycamore`.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…#4343) This allows users to specify an intercepting decomposer (i.e. one that runs before default decomposition behavior) and use structure-preserving behavior (i.e. keeping `CircuitOperation`s but decomposing their contents) in the same `decompose` call. This is a prerequisite for allowing `CircuitOperation`s in `cirq.optimized_for_sycamore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to specify an intercepting decomposer (i.e. one that runs before default decomposition behavior) and use structure-preserving behavior (i.e. keeping
CircuitOperations but decomposing their contents) in the samedecomposecall.This is a prerequisite for allowing
CircuitOperations incirq.optimized_for_sycamore.