Skip to content

GeneralizedAmplitudeDampingChannel docstring #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

asmuzsoy
Copy link
Contributor

@asmuzsoy asmuzsoy commented Aug 2, 2021

Updated the docstring for GeneralizedAmplitudeDampingChannel in an attempt to more clearly define p and gamma, and also reodered the the initialization method to match the declaration. Very small changes, any feedback is appreciated!

@asmuzsoy asmuzsoy requested review from cduck, vtomole and a team as code owners August 2, 2021 20:42
@asmuzsoy asmuzsoy requested a review from maffoo August 2, 2021 20:42
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 2, 2021
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 4, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 4, 2021
@CirqBot CirqBot merged commit fb91578 into quantumlib:master Aug 4, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 4, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Updated the docstring for GeneralizedAmplitudeDampingChannel in an attempt to more clearly define p and gamma, and also reodered the the initialization method to match the declaration. Very small changes, any feedback is appreciated!
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Updated the docstring for GeneralizedAmplitudeDampingChannel in an attempt to more clearly define p and gamma, and also reodered the the initialization method to match the declaration. Very small changes, any feedback is appreciated!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants