Skip to content

implement aspen qubits and devices #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

erichulburd
Copy link
Contributor

@erichulburd erichulburd commented Aug 3, 2021

This is a draft for supporting very basic topological validation for Rigetti Aspen and Octagonal qubits.

TODO:

  • Clean up docstrings in aspen_device.py

@erichulburd erichulburd requested review from cduck, vtomole and a team as code owners August 3, 2021 00:18
@erichulburd erichulburd requested a review from mpharrigan August 3, 2021 00:18
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 3, 2021
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
##############################################################################
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this class for? Generally, classes named utils are a bad code smell, since they attract a lot of miscellaneous unrelated functionality. If this is for testing, can we at least call it test_utils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a doc string explaining the function and renamed this file to something more specific about the decorator function.

Normally, we would provide a default kwarg value right within the function signature. The issue here is that we need to initialize the default value as a context value: with build_sync_client() as client:. For that purpose, we use the decorator function.

@erichulburd erichulburd force-pushed the support_rigetti_device branch from 0402021 to 9039460 Compare August 3, 2021 18:26
@erichulburd erichulburd changed the title draft: implement aspen qubits and devices implement aspen qubits and devices Aug 3, 2021
@erichulburd erichulburd force-pushed the support_rigetti_device branch 3 times, most recently from 0709dfe to 76a9c36 Compare August 6, 2021 17:00
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this looks mostly done, I added a couple of nits, please address those and then we can merge - I would love to merge it today / tomorrow morning so that we can add it in the release of v0.12 (Wed / Thu).

@balopat balopat added this to the v0.12 milestone Aug 10, 2021
@erichulburd erichulburd force-pushed the support_rigetti_device branch 3 times, most recently from 99cb4b1 to 2ef08cb Compare August 11, 2021 16:31
@erichulburd erichulburd force-pushed the support_rigetti_device branch from 2ef08cb to b05cdd4 Compare August 11, 2021 16:48
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 11, 2021
@CirqBot
Copy link
Collaborator

CirqBot commented Aug 11, 2021

Automerge cancelled: A required status check is not present.

Missing statuses: ['Build docs', 'Build protos', 'Coverage check', 'Doc test', 'Lint check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 11, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 11, 2021
@CirqBot CirqBot merged commit 66fd247 into quantumlib:master Aug 11, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 11, 2021
@erichulburd erichulburd deleted the support_rigetti_device branch August 17, 2021 23:55
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
This is a draft for supporting very basic topological validation for Rigetti Aspen and Octagonal qubits.

TODO:

* [x] Clean up docstrings in aspen_device.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants