-
Notifications
You must be signed in to change notification settings - Fork 1.1k
implement aspen qubits and devices #4378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement aspen qubits and devices #4378
Conversation
cirq-rigetti/cirq_rigetti/_util.py
Outdated
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this class for? Generally, classes named utils are a bad code smell, since they attract a lot of miscellaneous unrelated functionality. If this is for testing, can we at least call it test_utils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a doc string explaining the function and renamed this file to something more specific about the decorator function.
Normally, we would provide a default kwarg value right within the function signature. The issue here is that we need to initialize the default value as a context value: with build_sync_client() as client:
. For that purpose, we use the decorator function.
0402021
to
9039460
Compare
0709dfe
to
76a9c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - this looks mostly done, I added a couple of nits, please address those and then we can merge - I would love to merge it today / tomorrow morning so that we can add it in the release of v0.12 (Wed / Thu).
99cb4b1
to
2ef08cb
Compare
2ef08cb
to
b05cdd4
Compare
Automerge cancelled: A required status check is not present. Missing statuses: ['Build docs', 'Build protos', 'Coverage check', 'Doc test', 'Lint check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
This is a draft for supporting very basic topological validation for Rigetti Aspen and Octagonal qubits. TODO: * [x] Clean up docstrings in aspen_device.py
This is a draft for supporting very basic topological validation for Rigetti Aspen and Octagonal qubits.
TODO: