Add missing import cirq
#4387
Merged
Add missing import cirq
#4387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vtomole
previously requested changes
Aug 6, 2021
There was a problem hiding this comment.
Hey @MarkDaoust, you've added import cirq under an ImportError exception; which means the exception will be raised again except this time it won't be caught.
vtomole
reviewed
Aug 6, 2021
vtomole
reviewed
Aug 6, 2021
There was a problem hiding this comment.
One nit: could you move the second import statement down in order to be more consistent with other notebooks like https://github.com/quantumlib/Cirq/blob/master/docs/circuits.ipynb
|
Done. |
|
Thanks! |
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fix notebook, this is failing in the site import pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix notebook, this is failing in the site import pipeline.