Skip to content

Add missing code for ProjectorSum serialization in TFQ #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

tonybruguier
Copy link
Contributor

For issue #3288 I noticed that some code was missing when working on integrating with TFQ:
tensorflow/quantum#623

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 22, 2021
@CirqBot CirqBot added the size: S 10< lines changed <50 label Aug 22, 2021
@tonybruguier tonybruguier marked this pull request as ready for review August 22, 2021 05:03
@tonybruguier tonybruguier requested review from cduck, vtomole and a team as code owners August 22, 2021 05:03
@tonybruguier
Copy link
Contributor Author

I would suggest @MichaelBroughton as a reviewer, but happy to get advice from anyone.

Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 22, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 22, 2021
@CirqBot CirqBot merged commit 1c2eafb into quantumlib:master Aug 22, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 22, 2021
@tonybruguier tonybruguier deleted the proj_sum branch August 22, 2021 20:40
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
For issue quantumlib#3288 I noticed that some code was missing when working on integrating with TFQ:
tensorflow/quantum#623
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
For issue quantumlib#3288 I noticed that some code was missing when working on integrating with TFQ:
tensorflow/quantum#623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants