[cirqflow] Quantum runtime skeleton #4556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
commented
Oct 7, 2021
| import cirq.work | ||
|
|
||
|
|
||
| class AbstractEngineProcessorShim(metaclass=abc.ABCMeta): |
There was a problem hiding this comment.
- Depending on your timeframe and the timeframe for this PR, I propose including this shim for now
- This shim should inform your design of
AbstractEngineProcessor:)
There was a problem hiding this comment.
@dstrain115 thoughts?
- writing serialization tests - could be usefull
This was referenced Oct 11, 2021
CirqBot
pushed a commit
that referenced
this pull request
Oct 12, 2021
Skeleton of the constituent parts of `ExecutableGroupResult`  Most of these dataclasses only have barebones attributes which may beg the question: "why do we need a class for this?". Rest assured: I have big plans for adding more attributes to things. This is the first part; splitting up #4556
CirqBot
pushed a commit
that referenced
this pull request
Oct 18, 2021
Skeleton of the rest of `ExecutableGroupResult`  Most of these dataclasses only have barebones attributes which may beg the question: "why do we need a class for this?". Rest assured: I have big plans for adding more attributes to things. This follow #4565 ; splitting up #4556
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Skeleton of the constituent parts of `ExecutableGroupResult`  Most of these dataclasses only have barebones attributes which may beg the question: "why do we need a class for this?". Rest assured: I have big plans for adding more attributes to things. This is the first part; splitting up quantumlib#4556
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Skeleton of the rest of `ExecutableGroupResult`  Most of these dataclasses only have barebones attributes which may beg the question: "why do we need a class for this?". Rest assured: I have big plans for adding more attributes to things. This follow quantumlib#4565 ; splitting up quantumlib#4556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skeleton of
ExecutableGroupResult(note: name has changed since I last posted this diagram) and its members.Most of these dataclasses only have barebones attributes which may beg the question: "why do we need a class for this?". Rest assured: I have big plans for adding more attributes to things.
Similarly, the
executefunction is a wrapper around a for loop in this PR. That will likely change as the framework learns more runtime features like aBatcherorParallelizer.