Skip to content

Don't invoke json_cirq_type if cirq_type is defined...for now. #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

95-martin-orion
Copy link
Collaborator

Fixes a backwards-incompatibility in #4704.

This alternate return path is necessary until the deprecation cycle for this change is complete.

@95-martin-orion 95-martin-orion requested review from cduck, vtomole and a team as code owners November 24, 2021 22:42
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 24, 2021
@CirqBot CirqBot added the size: S 10< lines changed <50 label Nov 24, 2021
@95-martin-orion
Copy link
Collaborator Author

Thanks to @mpharrigan for the quick catch on this!

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 24, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 24, 2021
@CirqBot CirqBot merged commit 43a3280 into quantumlib:master Nov 24, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 24, 2021
@95-martin-orion 95-martin-orion deleted the depr-return branch November 24, 2021 23:08
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…umlib#4711)

Fixes a backwards-incompatibility in quantumlib#4704.

This alternate return path is necessary until the deprecation cycle for this change is complete.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…umlib#4711)

Fixes a backwards-incompatibility in quantumlib#4704.

This alternate return path is necessary until the deprecation cycle for this change is complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants