Skip to content

Add missing _has_*_ methods #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Add missing _has_*_ methods #4735

merged 1 commit into from
Dec 8, 2021
+33 −1

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Dec 8, 2021 •
edited
Loading

I missed them in #4550.

@viathor viathor requested review from cduck, vtomole and a team as code owners December 8, 2021 01:48
@viathor viathor requested a review from maffoo December 8, 2021 01:49
@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 8, 2021
@daxfohl
Copy link
Collaborator

daxfohl commented Dec 8, 2021

Should there be a check for this in the consistent protocols tester? It has a check for has_unitary.

@viathor
Copy link
Collaborator Author

viathor commented Dec 8, 2021

_has_superoperator_ is added in this PR for the first time and _has_kraus_ isn't covered by the consistency checks. We do have #4579 about adding utilities for checking consistency for channel implementations (and I just added a remark there to remember about the _has_*_ methods).

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 8, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 8, 2021
@CirqBot CirqBot merged commit 45fd829 into quantumlib:master Dec 8, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 8, 2021
@viathor viathor deleted the oops_has_superoperator branch December 8, 2021 17:54
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Add missing _has_*_ methods (quantumlib#4735)
4927fd1 
I missed them in quantumlib#4550.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@viathor
Add missing _has_*_ methods (quantumlib#4735)
01e20a2 
I missed them in quantumlib#4550.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanujkhattar tanujkhattar tanujkhattar approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

@mpharrigan mpharrigan Awaiting requested review from mpharrigan

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viathor @daxfohl @tanujkhattar @CirqBot