-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Close matplotlib figures after testing #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CirqBot
merged 4 commits into
quantumlib:master
from
pavoljuhas:close-mpl-figures-after-testing
Jan 8, 2022
Merged
Close matplotlib figures after testing #4810
CirqBot
merged 4 commits into
quantumlib:master
from
pavoljuhas:close-mpl-figures-after-testing
Jan 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the record the following patch can be used to find tests that leave opened figures. diff --git a/conftest.py b/conftest.py
index e74e741e..34bc013f 100644
--- a/conftest.py
+++ b/conftest.py
@@ -28,6 +28,14 @@ def pytest_configure(config):
config.addinivalue_line("filterwarnings", f"ignore:Call to deprecated create function {f}")
+import pytest
+@pytest.fixture(autouse=True)
+def failonleftoverfigures(request):
+ import matplotlib.pyplot as plt
+ yield
+ assert not plt.get_fignums()
+
+
def pytest_addoption(parser):
parser.addoption(
"--rigetti-integration", |
MichaelBroughton
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Automerge cancelled: There are merge conflicts. |
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Add test fixture that cleans up any open matplotlib figures and plug it in the tests that open new figures. Fix RuntimeWarning: More than 20 figures have been opened.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Add test fixture that cleans up any open matplotlib figures and plug it in the tests that open new figures. Fix RuntimeWarning: More than 20 figures have been opened.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Add test fixture that cleans up any open matplotlib figures and plug it in the tests that open new figures. Fix RuntimeWarning: More than 20 figures have been opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test fixture that cleans up any open matplotlib figures and
plug it in the tests that open new figures.
Fix RuntimeWarning: More than 20 figures have been opened.