-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make gate_sets actually optional #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gate_sets actually optional #4850
Conversation
- mypy and pycharm need a default value in the abstract interface in order to be truly optional. - Also, add a copy of the inherited arguments in SimulatedLocalProcessor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes here look like dangerous default values. Would it be possible for the optional case to do something like:
def my_method(some_optional_thing = None):
if some_optional_thing is None:
some_optional_thing = promote_to(somethingorother)
?
Changed. |
what about |
oh weird maybe I was looking at only a subset of commits |
- mypy and pycharm need a default value in the abstract interface in order to be truly optional. - Also, add a copy of the inherited arguments in SimulatedLocalProcessor.
- mypy and pycharm need a default value in the abstract interface in order to be truly optional. - Also, add a copy of the inherited arguments in SimulatedLocalProcessor.
in order to be truly optional.
SimulatedLocalProcessor.