-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor qcs_notebook to use application default creds #5045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
70d9476
Refactor qcs_notebook to use application default creds
maffoo c298fb6
Autoselect a processor if not specified
maffoo 6854e14
Disable erroneous lint check
maffoo 339bdf5
fmt
maffoo c70f456
Merge branch 'master' into u/maffoo/qcs-notebook
maffoo a45a1d3
Add nocover
maffoo f91edf4
Merge branch 'master' into u/maffoo/qcs-notebook
maffoo 83a294a
Minor refactors
maffoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this call + the try-except fulfills the role of the old
if project_id is None
check?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does that and more. Previously if you didn't specify a
project_id
the code would look for aGOOGLE_CLOUD_PROJECT
environment variable, and if that is not defined would not connect to quantum engine. With the new code, we delegate togoogle.auth.default()
whichget_engine
uses internally in the gapic machinery to get default credentials. This will still pull fromGOOGLE_CLOUD_PROJECT
if it is defined but will also respect other standard mechanisms of setting the project like if the user has usedgcloud config set project
. This is mostly an issue when connecting to a local jupyter backend, rather than running in hosted colab.