Skip to content

Use sorted instead of set for random.sample #5248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Use sorted instead of set for random.sample #5248

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2d31791
Fix random sample on set being deprecated
dabacon Apr 12, 2022
d29426c
use sorted
dabacon Apr 12, 2022
e5b1d95
Merge branch 'master' into warnings
dabacon Apr 13, 2022
2428cf6
Merge branch 'master' into warnings
dabacon Apr 13, 2022
36893b8
black
dabacon Apr 13, 2022
ae05445
Merge remote-tracking branch 'origin/warnings' into warnings
dabacon Apr 13, 2022
0ea3f3d
Merge branch 'master' into warnings
dabacon Apr 14, 2022
1f65905
Update circuit_test.py
dabacon Apr 14, 2022
ab23b7b
Update circuit_test.py
dabacon Apr 14, 2022
583c162
Update circuit_test.py
dabacon Apr 14, 2022
6bcff03
Update circuit_test.py
dabacon Apr 14, 2022
4496d6f
Merge branch 'master' into warnings
CirqBot Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cirq-core/cirq/circuits/circuit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3470,7 +3470,7 @@ def test_next_moments_operating_on(circuit_cls):
circuit = cirq.testing.random_circuit(randint(1, 20), n_moments, random())
circuit_qubits = circuit.all_qubits()
n_key_qubits = randint(int(bool(circuit_qubits)), len(circuit_qubits))
key_qubits = sample(circuit_qubits, n_key_qubits)
key_qubits = sample(sorted(circuit_qubits), n_key_qubits)
start = randrange(len(circuit))
next_moments = circuit.next_moments_operating_on(key_qubits, start)
for q, m in next_moments.items():
Expand Down Expand Up @@ -3521,7 +3521,7 @@ def test_push_frontier_random_circuit():
for _ in range(20):
n_moments = randint(1, 10)
circuit = cirq.testing.random_circuit(randint(1, 20), n_moments, random())
qubits = circuit.all_qubits()
qubits = sorted(circuit.all_qubits())
early_frontier = {q: randint(0, n_moments) for q in sample(qubits, randint(0, len(qubits)))}
late_frontier = {q: randint(0, n_moments) for q in sample(qubits, randint(0, len(qubits)))}
update_qubits = sample(qubits, randint(0, len(qubits)))
Expand Down