Skip to content

[cirqflow] run_start_time and run_end_time #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

mpharrigan
Copy link
Collaborator

Add run_start_time and run_end_time to cg.workflow.execute() SharedRuntimeInfo. This gives you an overview of when a given workflow run started and completed.

This is complementary to #5152 which will record a timestamp for each cirq.Result.

@mpharrigan mpharrigan requested a review from verult April 25, 2022 22:36
@mpharrigan mpharrigan requested review from wcourtney, a team, vtomole and cduck as code owners April 25, 2022 22:36
@mpharrigan mpharrigan requested a review from maffoo April 25, 2022 22:36
@CirqBot CirqBot added the size: S 10< lines changed <50 label Apr 25, 2022

@classmethod
def _json_namespace_(cls) -> str:
return 'cirq.google'

def _json_dict_(self) -> Dict[str, Any]:
d = dataclass_json_dict(self)
# TODO (gh-4699): serialize `device` as well once SerializableDevice is serializable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they changed my original issue title to be a little less ridiculous #4699

@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 27, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Apr 27, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 27, 2022
@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 27, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Apr 27, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 27, 2022
@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 27, 2022
@CirqBot CirqBot merged commit b452670 into quantumlib:master Apr 27, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 27, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Add `run_start_time` and `run_end_time` to `cg.workflow.execute()` `SharedRuntimeInfo`. This gives you an overview of when a given workflow run started and completed. 

This is complementary to quantumlib#5152 which will record a timestamp for each `cirq.Result`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants