Skip to content

Update Pasqal Tutorial Documentation #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2022

Conversation

dstrain115
Copy link
Collaborator

  • Update Pasqal documentation to use device validation
    rather than devices attached to circuits.
  • Clean up code so that repeated executions do not fail noise
    model or validation.
  • Clear output.
  • Add a few code comments.

- Update Pasqal documentation to use device validation
rather than devices attached to circuits.
- Clean up code so that repeated executions do not fail noise
model or validation.
- Clear output.
- Add a few code comments.
@dstrain115 dstrain115 requested review from HGSilveri, a team, vtomole and cduck as code owners April 30, 2022 12:21
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dstrain115 dstrain115 requested a review from maffoo April 30, 2022 12:21
@@ -75,7 +75,8 @@
"except ImportError:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    too_far_away_circuit = cirq.Circuit()

What's the need for this circuit? It seems it is never used


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Was a remnant of when the below operation was a circuit.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, it LGTM overall!

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 2, 2022
@dstrain115 dstrain115 merged commit c41fd8f into quantumlib:master May 2, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
* Update Pasqal Tutorial Documentation

- Update Pasqal documentation to use device validation
rather than devices attached to circuits.
- Clean up code so that repeated executions do not fail noise
model or validation.
- Clear output.
- Add a few code comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants