Skip to content

Median device calibrations #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2022

Conversation

95-martin-orion
Copy link
Collaborator

Adds methods for loading median calibration data for one of two devices.

This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.

@95-martin-orion 95-martin-orion requested a review from dstrain115 May 9, 2022 16:18
@95-martin-orion 95-martin-orion requested review from wcourtney, a team, vtomole, cduck and verult as code owners May 9, 2022 16:18
@CirqBot CirqBot added the size: XL lines changed >1000 label May 9, 2022
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit picks on this.


Real calibration data from Google's 'rainbow' and 'weber' devices has been
saved in Cirq. The calibrations selected are roughly representative of the
median performance for that chip.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth commenting (or linking to the docs) which metrics are included in this data?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, although I don't think the docs cover all of the metrics anymore.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should augment the docs then in a later PR.

@95-martin-orion 95-martin-orion requested a review from dstrain115 May 9, 2022 17:46

Real calibration data from Google's 'rainbow' and 'weber' devices has been
saved in Cirq. The calibrations selected are roughly representative of the
median performance for that chip.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should augment the docs then in a later PR.

median performance for that chip.

A description of the stored metrics can be found here:
https://quantumai.google/cirq/google/calibration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you doublecheck to make sure this is correct formatting?

See Dave's recent PR #5220
Not sure if this needs an {:.external} if it is on quantumai.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to match formatting. It seems like skipping the {:.external} is in the spirit of the TFdocs rule, though I don't know if the warnings Dave mentioned will see it that way :/

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 9, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 9, 2022
@CirqBot CirqBot merged commit 116c2b0 into quantumlib:master May 9, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 9, 2022
@95-martin-orion 95-martin-orion deleted the median-calibration branch May 10, 2022 15:25
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Adds methods for loading median calibration data for one of two devices.

This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL lines changed >1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants