-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Median device calibrations #5338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nit picks on this.
|
||
Real calibration data from Google's 'rainbow' and 'weber' devices has been | ||
saved in Cirq. The calibrations selected are roughly representative of the | ||
median performance for that chip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth commenting (or linking to the docs) which metrics are included in this data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, although I don't think the docs cover all of the metrics anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should augment the docs then in a later PR.
|
||
Real calibration data from Google's 'rainbow' and 'weber' devices has been | ||
saved in Cirq. The calibrations selected are roughly representative of the | ||
median performance for that chip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should augment the docs then in a later PR.
median performance for that chip. | ||
|
||
A description of the stored metrics can be found here: | ||
https://quantumai.google/cirq/google/calibration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you doublecheck to make sure this is correct formatting?
See Dave's recent PR #5220
Not sure if this needs an {:.external}
if it is on quantumai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to match formatting. It seems like skipping the {:.external}
is in the spirit of the TFdocs rule, though I don't know if the warnings Dave mentioned will see it that way :/
Adds methods for loading median calibration data for one of two devices. This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.
Adds methods for loading median calibration data for one of two devices.
This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.