Skip to content

Support prepending noise #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

95-martin-orion
Copy link
Collaborator

Fixes #2570.

This is essentially a more friendly version of #5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.

@95-martin-orion 95-martin-orion requested review from a team, vtomole and cduck as code owners May 26, 2022 20:56
@CirqBot CirqBot added the size: M 50< lines changed <250 label May 26, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this May 31, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented May 31, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 31, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
@CirqBot CirqBot merged commit ac7994e into quantumlib:master May 31, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 31, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Fixes quantumlib#2570.

This is essentially a more friendly version of quantumlib#5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Fixes quantumlib#2570.

This is essentially a more friendly version of quantumlib#5327 which maintains existing behavior but gives users the option to prepend noise (or append, in the case of readout error) on various noise models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should ConstantQubitNoiseModel apply noise first rather than second?
3 participants