Skip to content

Make all non-analytical gate decompositions respect global phase #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #4275

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners May 31, 2022 16:11
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one comment

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 31, 2022
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
@CirqBot CirqBot merged commit 0d55968 into master May 31, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 31, 2022
@CirqBot CirqBot deleted the decomp_respect_global_phase branch May 31, 2022 17:30
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gate decompositions ignore global phase
4 participants