Fix tests that break python-repeat #5431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
added
the
kind/health
MichaelBroughton
approved these changes
Jun 2, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
I use python-repeat to check for flaky tests. It allows you to pass in `--count XXX` to repeat a test multiple times. Interestingly, for parameterized tests the decorator that creates the parameterized tests is run once globally, and then the tests are repeated. This means that these tests can catch places where the parameterized values are mutated in some way during a test. This fixes the cases found from `check/pytest --count 100`. In general mutating parameters called to functions without being very explicit about it is something we should try to avoid.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
I use python-repeat to check for flaky tests. It allows you to pass in `--count XXX` to repeat a test multiple times. Interestingly, for parameterized tests the decorator that creates the parameterized tests is run once globally, and then the tests are repeated. This means that these tests can catch places where the parameterized values are mutated in some way during a test. This fixes the cases found from `check/pytest --count 100`. In general mutating parameters called to functions without being very explicit about it is something we should try to avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use python-repeat to check for flaky tests. It allows you to pass in
--count XXXto repeat a test multiple times. Interestingly, for parameterized tests the decorator that creates the parameterized tests is run once globally, and then the tests are repeated. This means that these tests can catch places where the parameterized values are mutated in some way during a test.This fixes the cases found from
check/pytest --count 100. In general mutating parameters called to functions without being very explicit about it is something we should try to avoid.