-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Deprecate optimize_for_sycamore and optimize_for_xmon #5531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate optimize_for_sycamore and optimize_for_xmon #5531
Conversation
…factor/optimize-deprecation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after updating the examples.
@verult Ideally, we need to create google-specific versions of cz and sqrt-iswap target gatesets, which correctly handle wait gates and have additional postprocess transformers like It would be good to evaluate whether the proposed fix (i.e. using |
Sounds good. I'm focusing on |
@MichaelBroughton and I chatted about this and we decided to postpone the evaluation until after the 0.15 release. If tests break, we could perhaps make a patch release to update the deprecation warning if it's not too time consuming to do. |
* Added deprecation warnings * Updated tests to check for deprecation warnings. @tanujkhattar @MichaelBroughton
* Added deprecation warnings * Updated tests to check for deprecation warnings. @tanujkhattar @MichaelBroughton
@tanujkhattar @MichaelBroughton