Use list comprehensions instead of list(filter(...))
#5578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list comprehensions are more idiomatic, don't require creating lambdas, and also end up being shorter when formatted.
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
dabacon
approved these changes
Jun 23, 2022
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
|
This PR has flaked due to #5574. Re-running. |
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
|
Re-ran 3 times. The flake absolutely can't go away. |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
The list comprehensions are more idiomatic, don't require creating lambdas, and also end up being shorter when formatted. Co-authored-by: Dave Bacon <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
The list comprehensions are more idiomatic, don't require creating lambdas, and also end up being shorter when formatted. Co-authored-by: Dave Bacon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list comprehensions are more idiomatic, don't require creating lambdas, and also end up being shorter when formatted.