Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @cached_method for FrozenCircuit properties #5707

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Jul 9, 2022

This also includes an optimization in the cached_method decorator for the case of methods that take no arguments other than self (as is often the case with cirq protocol methods, for example).

@maffoo maffoo requested review from a team, vtomole and cduck as code owners July 9, 2022 06:44
@maffoo maffoo requested a review from viathor July 9, 2022 06:44
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 9, 2022
@95-martin-orion 95-martin-orion self-assigned this Jul 11, 2022
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo failing test (can remove if fix is infeasible)

@maffoo maffoo added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
@CirqBot CirqBot merged commit 291502b into master Jul 11, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot deleted the u/maffoo/frozen-props branch July 11, 2022 16:27
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
This also includes an optimization in the `cached_method` decorator for the case of methods that take no arguments other than self (as is often the case with cirq protocol methods, for example).
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
This also includes an optimization in the `cached_method` decorator for the case of methods that take no arguments other than self (as is often the case with cirq protocol methods, for example).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants