Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve common_gates docstrings #5722

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Improve common_gates docstrings #5722

merged 4 commits into from
Jul 11, 2022

Conversation

95-martin-orion
Copy link
Collaborator

Bundle of minor fixes for docstrings in common_gates.py.

@95-martin-orion 95-martin-orion requested review from a team, vtomole and cduck as code owners July 11, 2022 20:46
@95-martin-orion 95-martin-orion requested a review from dabacon July 11, 2022 20:46
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 11, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 11, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 11, 2022
@95-martin-orion
Copy link
Collaborator Author

Failure is spontaneous kernel death in notebook; will retry when available.

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
@CirqBot CirqBot merged commit 4265d6d into master Jul 11, 2022
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot deleted the common-gate-polish branch July 11, 2022 23:15
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@95-martin-orion @rht
Improve common_gates docstrings (quantumlib#5722)
a3d68e2 
Bundle of minor fixes for docstrings in `common_gates.py`.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@95-martin-orion
Improve common_gates docstrings (quantumlib#5722)
7ed52e8 
Bundle of minor fixes for docstrings in `common_gates.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@95-martin-orion @CirqBot @dstrain115 @dabacon @MichaelBroughton