Add handling for sympy conditions in deferred measurement transformer #5824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@daxfohl Can you please add a description describing the change in this PR ?
4 tasks
|
Converting to draft until #5883 is approved |
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…quantumlib#5824) * Add handling for sympy conditions in deferred measurement transformer * docstring * mypy * mypy * cover * Make this more generic, covers all kinds of conditions. * Better docs * Sympy can also be CX * docs * docs * Add mixed tests, simplify loop, add simplification in ControlledGate * Fix error message * Simplify error message * Inline variable * fix merge * qudit sympy test * fix build * Fix test * Fix test * Remove need for ControlledGate change * mypy, comment * nits Co-authored-by: Tanuj Khattar <[email protected]>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…quantumlib#5824) * Add handling for sympy conditions in deferred measurement transformer * docstring * mypy * mypy * cover * Make this more generic, covers all kinds of conditions. * Better docs * Sympy can also be CX * docs * docs * Add mixed tests, simplify loop, add simplification in ControlledGate * Fix error message * Simplify error message * Inline variable * fix merge * qudit sympy test * fix build * Fix test * Fix test * Remove need for ControlledGate change * mypy, comment * nits Co-authored-by: Tanuj Khattar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the DeferredMeasurementTransformer could only work with classical conditions of type KeyCondition (triggered iff the measurement value of that key != zero). This PR enables the transformer to work with SympyConditions (which allow arbitrary classical logic with multiple keys in the trigger) as well.
We do this by calculating the truth table of the sympy condition, and constructing a quantum control that has the same truth table for the deferred measurement circuit. This approach actually applies to not only sympy conditions, but all classical control conditions. Thus we removed the existing logic for KeyCondition transformation.
Additionally this adds a control_values reduction in the ControlledGate constructor allowing us to remove the special case logic from the transformer.