Skip to content

Reduce atol in two qubit isometry analytical decompositions to fix failing tests on CI #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 25, 2022
Merged

Reduce atol in two qubit isometry analytical decompositions to fix failing tests on CI #5837

Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3a5160
Remove stale TODO
tanujkhattar Jun 29, 2022
198c2f7
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jun 29, 2022
cc4c875
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jun 30, 2022
ef3f3df
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jul 15, 2022
badb27e
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jul 16, 2022
232a6d5
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jul 18, 2022
7cebae5
Merge branch 'master' of https://github.com/quantumlib/cirq
tanujkhattar Jul 23, 2022
8700998
Merge branch 'master' of https://github.com/quantumlib/Cirq
tanujkhattar Jul 23, 2022
3159fdc
Merge branch 'master' of https://github.com/quantumlib/Cirq
tanujkhattar Aug 22, 2022
4fb7546
Merge branch 'master' of https://github.com/quantumlib/Cirq
tanujkhattar Aug 25, 2022
657819e
Reduce atol to fix flaky tests
tanujkhattar Aug 25, 2022
882fba9
Change atol to 1e-6
tanujkhattar Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cirq-core/cirq/transformers/analytical_decompositions/single_to_two_qubit_isometry_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def test_two_qubit_matrix_to_cz_isometry(
decomposed_final_state_vector = sim.simulate(decomposed_circuit).final_state_vector

assert (
cirq.allclose_up_to_global_phase(original_final_state_vector, decomposed_final_state_vector)
cirq.allclose_up_to_global_phase(
original_final_state_vector, decomposed_final_state_vector, atol=1e-5
)
is is_valid
)