Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for parameter resolution #5864

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Add benchmarks for parameter resolution #5864

merged 3 commits into from
Sep 8, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Part of #3840
cc https://github.com/qh-lab/pyle/issues/29309

The benchmarks produce the following output:

              --                                     num_scan_points                          
              ------------ -------------------------------------------------------------------
               num_qubits        20            40           60           80           100     
              ============ ============= ============= ============ ============ =============
                   50       18.9±0.04ms   37.8±0.06ms   57.4±0.9ms   75.7±0.1ms   94.0±0.09ms 
                  100        36.4±0.2ms    72.8±0.1ms   109±0.2ms    145±0.1ms      183±1ms   
                  150        53.6±0.1ms    107±0.2ms    162±0.2ms     215±1ms       267±1ms   
                  200        70.5±0.2ms     141±1ms      213±1ms      284±2ms      352±0.5ms  
              ============ ============= ============= ============ ============ =============

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners September 7, 2022 21:44
@CirqBot CirqBot added the size: S 10< lines changed <50 label Sep 7, 2022
pavoljuhas
pavoljuhas reviewed Sep 7, 2022
View reviewed changes
pavoljuhas
pavoljuhas approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after formatting fixups.

pavoljuhas
pavoljuhas approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Sep 7, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 7, 2022
@tanujkhattar tanujkhattar merged commit 2e351f4 into master Sep 8, 2022
@tanujkhattar tanujkhattar added area/performance size: S 10< lines changed <50 and removed size: S 10< lines changed <50 labels Jan 3, 2023
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add benchmarks for parameter resolution (quantumlib#5864)
ea5fb9d 
* Add benchmarks for parameter resolution

* Address feedback
@pavoljuhas pavoljuhas deleted the param_resolution_benchmarks branch January 22, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees

@dabacon dabacon

@maffoo maffoo

Labels
area/performance size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanujkhattar @CirqBot @pavoljuhas @dabacon @maffoo