-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add an improved stratifier #6067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
size: L
250< lines changed <1000
status/stale
This has been closed due to inactivity for an extended period of time.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new and improved stratifying method, and (at least tentatively) an option as to which stratification method to use.
The basic idea is to:
Improvements over the old stratifier (from #6013) include:
O((len(categories)+1)!)
).Test script (to run with a local version of
cirq
that contains this PR):NOTE: this PR is NOT COMPLETE at the moment. However, the PR is relatively long, so I thought to open it up for initial review. Apologies if that's not appropriate, in which case please let me know and I'll mark this PR as a draft for now.
The current TODO list is:
Tagging @tanujkhattar, who reviewed my last statifier PR (#6013).
Feedback greatly appreciated 🙂, as well as suggestions for how to cleanly deal with measurement/control keys.