CI - run pylint checks with dependencies installed #6163
Conversation
dill-0.3.6 is out and hopefully will not regress quantumlib#5383
Allow pylint to check arguments in function calls.
Use a single shape argument in numpy array.reshape().
pavoljuhas
force-pushed
the
ci-check-pylint-with-cirq-deps
branch
from
c9d2bde to
81a14e7
Compare
There was a problem hiding this comment.
FWIW, the method on ndarray does allow one to pass dimensions as separate arguments:
Unlike the free function numpy.reshape, this method on ndarray allows the elements of the shape parameter to be passed in as separate arguments. For example, a.reshape(10, 11) is equivalent to a.reshape((10, 11)).
according to documentation.
Still, I suppose it is a little bit more future-proof to write it this way in case it gets refactored.
Yes, the Thanks for the review! |
* Install all cirq dependencies for pylint check so pylint can verify arguments in function calls. * Fix pylint complaints on too-many-function-args by using a single shape argument for numpy array.reshape(). * Remove obsolete pin of the dill version. The current release dill-0.3.6 seems OK w/r to quantumlib#5383
dill-0.3.6 is out and hopefully will not regress #5383