-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI - deflake Isolated pytest Ubuntu
#6603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6603 +/- ##
==========================================
- Coverage 97.81% 97.81% -0.01%
==========================================
Files 1061 1061
Lines 91656 91659 +3
==========================================
+ Hits 89657 89658 +1
- Misses 1999 2001 +2 ☔ View full report in Codecov by Sentry. |
This partially reverts quantumlib#6593
…otebook test Cirq sources may be included in importlib.metadata.distributions. We exclude them from the check if pytest virtual environment changed.
Avoid conflict between parallel builds of the cirq-core wheel.
seaborn-0.12.0 is the first version compatible with the current colormap API in the matplotlib.
ci-daily is passing for this PR at cad05ec |
This reverts commit c1cc790.
dstrain115
approved these changes
May 16, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
Problem: `test_isolated_packages.py` is still flaky and can fail on parallel builds of a local `cirq_core` wheel. Solution: Use per-worker copy of the cirq-core sources so that parallel builds do not have conflicting build files. Follow-up to quantumlib#6593
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
test_isolated_packages.py
is still flaky and can fail onparallel builds of a local
cirq_core
wheel.Solution: Use per-worker copy of the cirq-core sources so that parallel
builds do not have conflicting build files.
Follow-up to #6593