-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve replace_version tool and development wheels #6626
Merged
pavoljuhas
merged 7 commits into
quantumlib:main
from
pavoljuhas:improve-replace_version-utility
May 31, 2024
Merged
Improve replace_version tool and development wheels #6626
pavoljuhas
merged 7 commits into
quantumlib:main
from
pavoljuhas:improve-replace_version-utility
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a shared git clone for the pristine work repository.
…ersion Make sure version is updated in the test files as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6626 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1061 1067 +6
Lines 91455 91518 +63
=======================================
+ Hits 89454 89517 +63
Misses 2001 2001 ☔ View full report in Codecov by Sentry. |
NoureldinYosri
approved these changes
May 31, 2024
pavoljuhas
added a commit
to pavoljuhas/Cirq
that referenced
this pull request
Jun 26, 2024
- Make `dev_tools/modules.py replace_version` update also the version expected in unit tests - Skip type check in the new test-only source files - Update `dev_tools/packaging/produce-package.sh` to use the `replace_version` utility when building development wheels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
dev_tools/modules.py replace_version
update also theversion expected in unit tests
Skip type check in the new test-only source files
Update
dev_tools/packaging/produce-package.sh
to use thereplace_version
utility when building development wheels