Skip to content

Fix isolated notebooks tests against stable Cirq #7127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

pavoljuhas
Copy link
Collaborator

Pre-install a working version of qcs-sdk-python package.

Ref: rigetti/qcs-sdk-rust#531
Ref: #7126

Preinstall a working version of qcs-sdk-python package.

Ref: rigetti/qcs-sdk-rust#531
Ref: quantumlib#7126
@pavoljuhas pavoljuhas requested review from vtomole and a team as code owners March 7, 2025 00:53
@CirqBot CirqBot added the Size: XS <10 lines changed label Mar 7, 2025
@pavoljuhas pavoljuhas requested a review from dstrain115 March 7, 2025 00:53
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (78d30e7) to head (8eb5775).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7127      +/-   ##
==========================================
- Coverage   98.16%   98.15%   -0.01%     
==========================================
  Files        1093     1093              
  Lines       95420    95420              
==========================================
- Hits        93665    93661       -4     
- Misses       1755     1759       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mhucka mhucka added this pull request to the merge queue Mar 7, 2025
@pavoljuhas
Copy link
Collaborator Author

Thanks for fixing this!

fingers crossed there is no other way for this to bite.

Merged via the queue into quantumlib:main with commit 34b9c81 Mar 7, 2025
38 checks passed
@pavoljuhas pavoljuhas deleted the ci-fix-isolated-nb-test branch March 7, 2025 02:39
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request Apr 8, 2025
The recent release qcs-sdk-python-0.21.18 should be fixed per
rigetti/qcs-sdk-rust#531 (comment)

This rolls back quantumlib#7127 and quantumlib#7126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants