Simplify python package description #7187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip `cirq_ts` which does not have the `__version__` attribute.
Make setup.py files simpler and independent of CIRQ_PRE_RELEASE_VERSION. PyPI makes it already clear enough if looking at a development version.
Make it less mysterious how is the `__version__` value set.
`io.open` is an alias for `open` anyway.
Address setuptools notice to that effect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7187 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1100 1100
Lines 96194 96191 -3
==========================================
- Hits 94412 94409 -3
Misses 1782 1782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
requested review from
vtomole,
a team,
HGSilveri,
dabacon,
wcourtney and
verult
as code owners
pavoljuhas
force-pushed
the
simplify-setup-description
branch
from
a2920c8 to
9d8d75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conditional dev-release note from package description as
PyPI makes it clear enough when user visits development release.
Make setup.py independent of
CIRQ_PRE_RELEASE_VERSION.Validate dev-version value in packaging_test.sh
Use
runpyinstead ofexecto obtain version value.Make it less mysterious how is the
__version__obtained.Clean up calls to io.open() which is an alias to open().
Normalize
.devversion value to.dev0per setuptools notice.