Skip to content

Do mild editing for grammar, consistency, and Markdown #7246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Apr 8, 2025

In one document, the constructs in a list of cards were not parallel. In other places, just fiddled with constructs that struck me as awkward.

In several *.md files, added missing Markdown code block language tags.

mhucka and others added 3 commits April 8, 2025 13:59
In one document, the constructs in a list of cards were not parallel.
In other places, just fiddled with constructs that struck me as
awkward.
@mhucka mhucka marked this pull request as ready for review April 8, 2025 21:03
@mhucka mhucka requested review from wcourtney, vtomole, verult and a team as code owners April 8, 2025 21:03
@mhucka mhucka requested a review from pavoljuhas April 8, 2025 21:03
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (b199b21) to head (398cdb3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7246   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files        1106     1106           
  Lines       95990    95990           
=======================================
+ Hits        94687    94690    +3     
+ Misses       1303     1300    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the correction below to address yamllint. Thank you!

diff --git a/docs/experiments/_index.yaml b/docs/experiments/_index.yaml
index a66e9d42..ff9b9b75 100644
--- a/docs/experiments/_index.yaml
+++ b/docs/experiments/_index.yaml
@@ -29,5 +29,5 @@ landing_page:
     - heading: Variational Quantum Eigensolver
       description: An example of computing the ground state of a Hamiltonian using the
-      variational principle.
+        variational principle.
       path: /cirq/experiments/variational_algorithm
     - heading: Quantum Walks

@mhucka mhucka enabled auto-merge April 9, 2025 01:41
@mhucka mhucka disabled auto-merge April 9, 2025 03:17
@pavoljuhas pavoljuhas enabled auto-merge April 9, 2025 04:38
@pavoljuhas pavoljuhas added the priority/before-1.5 Finish before the Cirq 1.5 release label Apr 9, 2025
@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 9, 2025
Merged via the queue into quantumlib:main with commit 6fd52aa Apr 9, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/before-1.5 Finish before the Cirq 1.5 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants