Skip to content

Correct minor typo in BitMaskKeyCondition #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

dstrain115
Copy link
Collaborator

  • Noticed it while using the example code.

- Noticed it while using the example code.
@dstrain115 dstrain115 requested review from vtomole and a team as code owners April 8, 2025 22:30
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also patch here -

diff --git a/docs/build/classical_control.ipynb b/docs/build/classical_control.ipynb
index 0cfc9143..8bb7c549 100644
--- a/docs/build/classical_control.ipynb
+++ b/docs/build/classical_control.ipynb
@@ -202,3 +202,3 @@
     "The `cirq.KeyedCondition` class limited in that it evaluate a simple function `is the value != 0?`. When doing multi-qubit measurement we often need to do more complex function like applying a bitmask before comparison. The class [cirq.BitMaskKeyCondition](https://github.com/quantumlib/Cirq/blob/ebef9bff978f28b032f54eb5f0a2e1cb9ec6464c/cirq-core/cirq/value/condition.py#L140) provides this functionality allowing us to do:\n",
-    "- `BitMaskKeycondition('a')` $\\rightarrow a \\neq 0$\n",
+    "- `BitMaskKeyCondition('a')` $\\rightarrow a \\neq 0$\n",
     "- `BitMaskKeyCondition('a', bitmask=13)` $\\rightarrow  (a \\& 13) \\neq 0$\n",

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (9b367de) to head (ba2788d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7251      +/-   ##
==========================================
- Coverage   98.64%   98.64%   -0.01%     
==========================================
  Files        1106     1106              
  Lines       95990    95990              
==========================================
- Hits        94692    94690       -2     
- Misses       1298     1300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas enabled auto-merge April 9, 2025 02:43
@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@pavoljuhas pavoljuhas enabled auto-merge April 9, 2025 04:19
@pavoljuhas pavoljuhas added this pull request to the merge queue Apr 9, 2025
@pavoljuhas pavoljuhas added the priority/before-1.5 Finish before the Cirq 1.5 release label Apr 9, 2025
Merged via the queue into quantumlib:main with commit cc4f208 Apr 9, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/before-1.5 Finish before the Cirq 1.5 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants